Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create harvest db #36

Merged
merged 7 commits into from
Mar 11, 2024
Merged

Create harvest db #36

merged 7 commits into from
Mar 11, 2024

Conversation

Jin-Sun-tts
Copy link
Collaborator

Pull Request

Related to Create Harvest DB and Table Structure

About

  • Defined Table Structure in SQLAlchemy
  • Initialized this structure into a local Docker PostgresSQL container
  • Created interfaces to interact with the DB
  • Created Flask app (https://harvesting-logic.app.cloud.gov/) to test the harvester operations into the DB
  • Created manifest file for deployment to cloud.gov with PostgresSQL aws-rds micro-sql service.
  • Added tests with local PostgresSQL container.

@Jin-Sun-tts Jin-Sun-tts marked this pull request as draft February 26, 2024 18:27
Copy link

github-actions bot commented Feb 26, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
harvester
   __init__.py00100% 
   ckan_utils.py4222 95%
   harvest.py4116767 84%
   utils.py4377 84%
harvester/database
   __init__.py222 0%
   init_db.py101010 0%
   interface.py606060 0%
   models.py393939 0%
TOTAL60718769% 

Tests Skipped Failures Errors Time
22 0 💤 0 ❌ 0 🔥 2.381s ⏱️

@Jin-Sun-tts
Copy link
Collaborator Author

moved to datagov-harvest-orchestrator repo

@Jin-Sun-tts Jin-Sun-tts closed this Mar 4, 2024
@Jin-Sun-tts Jin-Sun-tts mentioned this pull request Mar 6, 2024
4 tasks
@Jin-Sun-tts
Copy link
Collaborator Author

back from datagov-harvest-orchestrator repo, reopen this.

@Jin-Sun-tts Jin-Sun-tts reopened this Mar 6, 2024
@Jin-Sun-tts Jin-Sun-tts marked this pull request as ready for review March 7, 2024 18:04
@Jin-Sun-tts Jin-Sun-tts requested a review from a team March 7, 2024 18:05
jbrown-xentity
jbrown-xentity previously approved these changes Mar 7, 2024
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jin-Sun-tts ! Some comments for your and the @GSA/data-gov-team 's awareness/review, some of these are general comments and some should be addressed before merging. I'm going to approve though, in case we need to get this merged and circle back to the improvements later.

.profile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
app.py Show resolved Hide resolved
create_cloudgov_service.sh Show resolved Hide resolved
harvester/database/interface.py Show resolved Hide resolved
harvester/database/interface.py Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
app.py Show resolved Hide resolved
app.py Show resolved Hide resolved
app.py Show resolved Hide resolved
app.py Show resolved Hide resolved
harvester/database/models.py Outdated Show resolved Hide resolved
harvester/database/models.py Show resolved Hide resolved
tests/database/test_db.py Show resolved Hide resolved
README.md Show resolved Hide resolved
@Jin-Sun-tts Jin-Sun-tts merged commit ebbdbde into main Mar 11, 2024
6 of 7 checks passed
@Jin-Sun-tts Jin-Sun-tts deleted the create-harvest-db branch March 11, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants