sqlite foreign key & db fixes #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l to flask app init; fixes dependency update script; runs update;
rshewitt
reviewed
May 9, 2024
rshewitt
approved these changes
May 9, 2024
|
based on this failed action run there is still some work to be done on actions setup with env vars. going to merge this anyway though as it fixes the db issues https://github.com/GSA/datagov-harvesting-logic/actions/runs/9022796421/job/24793348195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Issue noticed after
make cleanthat tables were not getting created on app init. Also noticed that foreign key constraints were not respected in tests.PR TASKS