fix: make sure bounds for images are set consistently when using center with nx/ny
#122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter` with `nx`/`ny`
CodSpeed Performance ReportMerging #122 will not alter performanceComparing Summary
|
Collaborator
Author
|
@ismael-mendoza can you take a look at this one? See the linked galsim issue for the bug description etc. if you are curious. |
Collaborator
|
sure - will take a look later today |
ismael-mendoza
approved these changes
Dec 11, 2024
Collaborator
ismael-mendoza
left a comment
ismael-mendoza
left a comment
There was a problem hiding this comment.
It looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the counterpart to GalSim-developers/GalSim#1323 and fixes the same bug.
To Do: