Skip to content

Conversation

@beckermr
Copy link
Collaborator

@beckermr beckermr commented Dec 19, 2024

This PR adds a benchmark for the Spergel profile. I can indeed confirm it is a few times slower than galsim on the CPU.

xref: #123

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #125 will not alter performance

Comparing spergel-bench (49872d8) with main (1e270c4)

Summary

✅ 11 untouched benchmarks
🆕 6 new benchmarks

Benchmarks breakdown

Benchmark main spergel-bench Change
🆕 test_benchmark_spergel_conv[compile] N/A 3.3 s N/A
🆕 test_benchmark_spergel_conv[run] N/A 2.6 s N/A
🆕 test_benchmark_spergel_kvalue[compile] N/A 698.2 ms N/A
🆕 test_benchmark_spergel_kvalue[run] N/A 137.2 ms N/A
🆕 test_benchmark_spergel_xvalue[compile] N/A 27.7 s N/A
🆕 test_benchmark_spergel_xvalue[run] N/A 24.5 s N/A

@beckermr beckermr marked this pull request as ready for review December 20, 2024 15:38
@ismael-mendoza ismael-mendoza self-requested a review January 2, 2025 17:50
Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @beckermr this looks good to me! Perhaps consider adding a benchmark with the HLR liked we talked about?

@beckermr beckermr merged commit ae6c7ee into main Jan 10, 2025
7 checks passed
@beckermr beckermr deleted the spergel-bench branch January 10, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants