refactor: remove RescheduleIn and RescheduleAt from JobCompletion#55
Open
nicolasburtey wants to merge 1 commit intomainfrom
Open
refactor: remove RescheduleIn and RescheduleAt from JobCompletion#55nicolasburtey wants to merge 1 commit intomainfrom
nicolasburtey wants to merge 1 commit intomainfrom
Conversation
Remove RescheduleIn, RescheduleInWithOp, RescheduleInWithTx, RescheduleAt, RescheduleAtWithOp, and RescheduleAtWithTx variants from JobCompletion. Callers should use RescheduleNow* variants instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
This removes the ability for cron-style jobs... I don't understand |
Member
Author
|
there are not any cron-job left since refactoring to EOD for many events. cron job are incompatible with a manual clock / more deterministic system, so we should just not allow them |
Member
|
What about fetching price in an interval? |
Member
Author
|
afaik they are permanent job that just sleep between price fetch, ie the job run forever and just sleep in its own "thread" between price update |
Member
Author
|
But maybe there is one use case for it: if there is a margin call and a 24h or 48h to react for the customer. Not sure how this would be implemented without this. We don't do this type of margin call yet |
Member
|
I wouldn't remove these just yet... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RescheduleIn,RescheduleInWithOp,RescheduleInWithTxvariants fromJobCompletionRescheduleAt,RescheduleAtWithOp,RescheduleAtWithTxvariants fromJobCompletionRescheduleNow*variants insteadTest plan
cargo check --features es-entitypasses🤖 Generated with Claude Code
Note
Medium Risk
Medium risk because this is a breaking public API change that removes
JobCompletion::RescheduleIn*/RescheduleAt*and corresponding dispatcher handling, requiring downstream callers to change how they schedule follow-up work.Overview
Removes the delayed (
RescheduleIn*) and absolute-time (RescheduleAt*) rescheduling outcomes fromJobCompletion, leaving only the immediateRescheduleNow*variants.The dispatcher no longer matches or applies duration/timestamp-based reschedules, and crate docs were updated to reflect the reduced rescheduling API (including dropping
chronousage fromrunner.rs).Written by Cursor Bugbot for commit b981cdd. This will update automatically on new commits. Configure here.