refactor(job): remove cancel_job API#67
Merged
HonestMajority merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
Consumers handle cancellation at their own layer, so the crate-level cancel_job method, Cancelled event variant, CannotCancelJob error, and related tests are no longer needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bodymindarts
force-pushed
the
task/remove-cancel-job-api-019d19bd
branch
from
2b45f38 to
93540fc
Compare
HonestMajority
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancel_job()public method fromJobsservice and unusedAtomicOperationimportCancelledevent variant fromJobEventenum and relatedcancel()/cancelled()methods from the entityCannotCancelJoberror variant fromJobErrortest_cancel_pending_job,test_cancel_running_job_fails,test_cancel_already_completed_job_is_idempotent)Consumers handle cancellation at their own layer, so the crate-level API is no longer needed.
Test plan
nix flake checkpasses (fmt, clippy, deny, audit)🤖 Generated with Claude Code