refactor: adjust the interface to adapt to reth #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshinGau
reviewed
Nov 15, 2024
|
|
||
| [dependencies] | ||
| revm = "14.0.0" | ||
| revm = { package = "revm", git = "https://github.com/nekomoto911/revm", branch = "v14.0.0" } |
There was a problem hiding this comment.
Why use the custom revm project
There was a problem hiding this comment.
At present, we need to add serde traits to some basic types of revm for test.
In the future, there will be more places where we need to apply patches (e.g. add some debug log) to the revm version we are using.
There was a problem hiding this comment.
Maybe consider maintainning revm repo in Galxe organization.
There was a problem hiding this comment.
Maybe consider maintainning revm repo in Galxe organization.
agree, let's do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block_onin the block thread pool if already in the tokio async context