Improved Stats on graphs page #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garllon
reviewed
May 7, 2021
| class AddPeopleInHouseholdToUsers < ActiveRecord::Migration[6.1] | ||
| def change | ||
| add_column :users, :people_in_household, :integer, default: 1 | ||
| User.all.each do |user| |
Owner
There was a problem hiding this comment.
Normally this is not a good practise and i would think this will also fail, when you run rollback.
Garllon
reviewed
May 7, 2021
| %th Source | ||
| %tbody | ||
| - GraphPresenter::GARBAGE.each do |key, value| | ||
| - household_weight = Pile.where(user_id: current_user.id).where(kind: key).group("DATE_TRUNC('month', produced_at)").sum(:weight).values.first |
Owner
There was a problem hiding this comment.
This should go to a presenter, but anywise my plan was also to refactor the whole logic, so maybe currently i see this as a optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check this out: Run the migration to add the new
people_in_householdfield to the User model. Then head over to thegraphspage and learn about this month's waste with an overview about how your household is doing and how it's going per-person.The statistics are not super beautified, but as a feature I call it MVP. ;)