Local-events CRUD - #28
Conversation
|
All of my local-events tests pass locally but some user auth and tmdb tests are failing. My endpoints and their tests are isolated so these can probably be reviewed but please check Slack |
alisryan
left a comment
alisryan
left a comment
There was a problem hiding this comment.
Your work looks good! A bunch of schema changes need to be made though, basically you nuked the schema for movies/users/ratings etc. when you rebased. No big deal but this needs to be fixed before merging for sure!
| model UserProfile { | ||
| userId String @id @db.Uuid | ||
| username String? | ||
| preferredLanguages String[] @default([]) | ||
| preferredCategories String[] @default([]) |
There was a problem hiding this comment.
I think the auth tests are failing because you deleted the schema, can you revert this change?
There was a problem hiding this comment.
I could change this locally but I'm curious how to solve this in a permanent way. Every time I run the docker script they're getting rewritten because it's pulling from the prod DB.
| web_authn_credential Json? | ||
| web_authn_aaguid String? @db.Uuid | ||
| mfa_challenges mfa_challenges[] | ||
| users auth_users @relation(fields: [user_id], references: [id], onDelete: Cascade, onUpdate: NoAction) |
There was a problem hiding this comment.
Why are we changing auth_users to users at all of these places?
| title String? | ||
| description String? | ||
| numRatings String? | ||
| model local_event { |
There was a problem hiding this comment.
TBH I think when you rebased you nuked all the changes to the schema besides yours that happened since you opened your branch, can you undo this?
3 participants
Description
Link to Ticket
Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!
How Has This Been Tested?
Running endpoint testing on the dev db.
Checklist