Skip to content

searching and filtering - #34

Closed
aamogh16 wants to merge 5 commits into
mainfrom
backend/search-filter/amogh
Closed

aamogh16 wants to merge 5 commits into
mainfrom
backend/search-filter/amogh

Conversation

@aamogh16

Copy link
Copy Markdown
Contributor

Description

Link to Ticket

Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. If they are unit
tests, provide the file name the tests are in. If they are not unit tests,
describe how you tested the change.

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@github-actions
github-actions Bot requested review from alisryan and danctila October 10, 2025 23:40
@aamogh16 aamogh16 changed the title added functionality to search a movie by keyword in title or description, with several filters searching and filtering Oct 10, 2025

@danctila danctila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amogh - looks great. Like how you structured the controller. I requested a couple changes and a third would just to be include some testing for your new routes. Fire work brother ☝️

Also just remembered - make sure to pull from main once you see this since there are changes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - if you could just make sure that you write in the description in the PR or in a comment somewhere (that will stay visible) so we know the current scope of the search functionality we have an what is left (also check off any items you hit in the initial ticket)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add /api as a prefix to your routes so they are auth protected?

@aamogh16

Copy link
Copy Markdown
Contributor Author

current available searching:

  • local database
  • TMDB if insufficient data
  • users
  • reviews
  • posts

@danctila danctila linked an issue Oct 20, 2025 that may be closed by this pull request
11 tasks
@danctila danctila closed this Nov 24, 2025
@danctila danctila mentioned this pull request Dec 2, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BE: Searching / Filtering

2 participants