Conversation
…ion, with several filters
There was a problem hiding this comment.
Amogh - looks great. Like how you structured the controller. I requested a couple changes and a third would just to be include some testing for your new routes. Fire work brother ☝️
Also just remembered - make sure to pull from main once you see this since there are changes
There was a problem hiding this comment.
This LGTM - if you could just make sure that you write in the description in the PR or in a comment somewhere (that will stay visible) so we know the current scope of the search functionality we have an what is left (also check off any items you hit in the initial ticket)
There was a problem hiding this comment.
Could you add /api as a prefix to your routes so they are auth protected?
|
current available searching:
|
Description
Link to Ticket
Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. If they are unit
tests, provide the file name the tests are in. If they are not unit tests,
describe how you tested the change.
Checklist