[WIP] FE API Service - #35
Merged
Merged
Conversation
…frontend-api-service
danctila
requested changes
Oct 12, 2025
danctila
left a comment
danctila
left a comment
Contributor
There was a problem hiding this comment.
Looks good I just requested a few changes. One of them is a bit larger and there is a comment in models.ts explaining my recommendation to add a type transformation layer in our controller handlers.
…into frontend-api-service
…frontend-api-service
…frontend-api-service
Closed
1 task
…into frontend-api-service
…into frontend-api-service
…into frontend-api-service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Link to Ticket
created apiclient, and services for the types, then wrote tests for the client and services
How Has This Been Tested?
wrote some unit and api tests
Checklist