Tutorial 6. Animations #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esteban82
requested review from
yvonnefroehlich,
weiji14,
maxrjones,
jhtong33 and
andrebelem
yvonnefroehlich
added
enhancement
Sphinx extension used to define the `gmtplot` directive that will execute the given GMT code and insert the generated figure into the document. Need to set `highlight_language: bash` otherwise there will be an `UnboundLocalError: cannot access local variable 'suffix' where it is not associated with a value`.
weiji14
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Thanks @Esteban82, this looks amazing, really like how you go through building an animation step by step from a simple frame to the final full resolution animation.
I've pushed some changes related to the Sphinx configuration to get the GMT code/plots and Youtube links to render (based on GenericMappingTools/gmt-examples#37). Only have one suggestion below to change the title of the extended tutorial, but will merge this directly afterwards. Feel free to make any changes after this PR is merged (e.g. typos, extra notes, etc) if needed before the workshop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add the docs. I split the file that I made for gmt-examples in two.
The idea is only explain tutorial 1 and let the participants to see tutorial 2 if they want.
Original PR at GenericMappingTools/gmt-examples#40