Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the -U+t (i.e. without any argument to the +t modifier) plot no stamp at all. #8616

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

joa-quim
Copy link
Member

Now this plots only the GMT logo and nothing else. Before this PR it still plotted the time stamp.

gmt plot -R0/3/0/0.1 -Jx1i -U+t -T  -view GMT_-U

@joa-quim joa-quim requested a review from a team November 14, 2024 01:39
@Esteban82
Copy link
Member

I got this with master

GMT_-U_previo

and this with this branch

GMT_-U

I use this command with png (instead of view). Is view a thing? I got a weird message.

gmt plot -R0/3/0/0.1 -Jx1i -U+t -T -png GMT_-U

@joa-quim
Copy link
Member Author

I confess I just learnt about the -view in https://docs.generic-mapping-tools.org/latest/reference/options.html#timestamps-on-plots-the-u-option

But yes, the plots you posted correctly show the situation. +t is supposed to replace the time stamp but only worked if it has an argument. A trick was to set +t" " but that is ugly and hard to discover.

@rbdavis
Copy link
Contributor

rbdavis commented Nov 14, 2024 via email

@seisman
Copy link
Member

seisman commented Nov 14, 2024

Yes, Roger is in the core group. I can remove him from the "core" group or maybe we can have a "gmt-core" team for people who'd like to review the GMT C project.

@joa-quim
Copy link
Member Author

I just removed Roger (and Paul) from the 'core' group. And yes, we could have a team for reviews, but how different would it be from 'core'?

@seisman
Copy link
Member

seisman commented Nov 14, 2024

Actually, we already have a "gmt-maintainers" team (https://github.com/orgs/GenericMappingTools/teams).

image

@joa-quim
Copy link
Member Author

Where, curiously, I am not in. Sure I can add me, but I still think the 'core' is the right group for asking/informing about new PR's.

@seisman
Copy link
Member

seisman commented Nov 14, 2024

There are some discussions in #4732.

@joa-quim joa-quim merged commit 184cc55 into master Nov 14, 2024
15 of 18 checks passed
@joa-quim joa-quim deleted the U+t_empty branch November 14, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants