-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let the -U+t (i.e. without any argument to the +t modifier) plot no stamp at all. #8616
Conversation
I confess I just learnt about the -view in https://docs.generic-mapping-tools.org/latest/reference/options.html#timestamps-on-plots-the-u-option But yes, the plots you posted correctly show the situation. +t is supposed to replace the time stamp but only worked if it has an argument. A trick was to set |
Hi Roger,
I'm not cc'ing anyone. You are probably receiving these messages because you are (to be confirmed) in the 'core' group that I indeed select for reviewing the PR's I submit.
Cheers
Joaquim
…-----Original Message-----
From: rbd ***@***.***>
Sent: Thursday, November 14, 2024 2:03 AM
To: GenericMappingTools/gmt ***@***.***>
Cc: GenericMappingTools/gmt ***@***.***>; Review requested ***@***.***>; Joaquim Manuel Freire Luís ***@***.***>
Subject: Re: [GenericMappingTools/gmt] Let the -U+t (i.e. without any argument to the +t modifier) plot no stamp at all. (PR #8616)
Hi all,
I am glad to see that work is continuing on GMT and hope that you are all doing well. However, considering that I am not actively working on GMT at the moment, it would be great if you all could stop specifically cc'ing me on these messages. See the quoted mailer header below, noting the line
Cc: Roger Davis ***@***.***>
which someone (I think perhaps Joaquim, as the threads I receive are usually initiated by him) appears to be manually adding somewhere in the message posting process. I disabled all of my GitHub notifications on this project long ago and can only assume that I am still receiving this material because of the specific 'Cc: Roger Davis' on these threads.
I would be very grateful if you guys could drop my address from the specific cc list on these messages, unless of course you really do want my opinion on something, which I suspect is generally not the case.
Thanks!
Roger
On Wed, 13 Nov 2024, Joaquim wrote:
Date: Wed, 13 Nov 2024 17:39:48 -0800
From: Joaquim ***@***.***>
Reply-To: GenericMappingTools/gmt
***@***.***>
To: GenericMappingTools/gmt ***@***.***>
Cc: Roger Davis ***@***.***>,
Review requested ***@***.***>
Subject: [GenericMappingTools/gmt] Let the -U+t (i.e. without any
argument to the +t modifier) plot no stamp at all. (PR #8616)
Now this plots only the GMT logo and nothing else. Before this PR it
still plotted the time stamp.
gmt plot -R0/3/0/0.1 -Jx1i -U+t -T -view GMT_-U
______________________________________________________________________
______
You can view, comment on, or merge this pull request online at:
#8616
Commit Summary
* efa03dc Let the -U+t (i.e. without any argument to the +t modifier) plot
no stamp at all.
File Changes
(2 files)
* M src/gmt_init.c (29)
* M src/gmt_plot.c (9)
Patch Links:
* https://github.com/GenericMappingTools/gmt/pull/8616.patch
* https://github.com/GenericMappingTools/gmt/pull/8616.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review
wasrequested.[ADEMQV3YSF4EHNAWUA6QWPD2AP5OJA5CNFSM6AAAAABRXZG7LKWGG33N
NVSW45C7 OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHJ4YVDIU.gif] Message ID:
***@***.***>
|
Yes, Roger is in the core group. I can remove him from the "core" group or maybe we can have a "gmt-core" team for people who'd like to review the GMT C project. |
I just removed Roger (and Paul) from the 'core' group. And yes, we could have a team for reviews, but how different would it be from 'core'? |
Actually, we already have a "gmt-maintainers" team (https://github.com/orgs/GenericMappingTools/teams). |
Where, curiously, I am not in. Sure I can add me, but I still think the 'core' is the right group for asking/informing about new PR's. |
There are some discussions in #4732. |
Now this plots only the GMT logo and nothing else. Before this PR it still plotted the time stamp.