Slightly increase the RMS value for test/grdvector/shrink.sh #8665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remkos
approved these changes
Jan 4, 2025
I don't believer this round-off theory (round-offs occur at 1e-16 bits) but don't have strong enough motivation to dig-up this behavior. So, good to me too. |
joa-quim
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
test/grdvector/shrink.shhas been failing for a long time.Here is the diff image. As you can see, the only difference is in the arrow of the 3rd row, east hemisphere (near (160, -10)). This difference is most likely caused by numerical round-off errors, so I think the test can be safely ignored. This PR increases the RMS value to make the test pass.