-
Notifications
You must be signed in to change notification settings - Fork 230
Figure.logo: Let the 'style' parameter support descriptive arguments #4074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the style
parameter in the Figure.logo
method to accept more descriptive string arguments instead of single-letter codes. The change improves code readability by allowing "standard"
, "url"
, and "no_label"
instead of cryptic "l"
, "u"
, and "n"
values.
- Updated the
style
parameter to use descriptive literal types with proper type hints - Implemented alias mapping to convert descriptive names to GMT's single-letter codes
- Updated documentation to reflect the new descriptive parameter values
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Hmm, I'm getting a 403 when trying to access https://dagshub.com/GenericMappingTools/pygmt, server might be down or something. |
I can access the website, and I can even run |
Same for me. |
I prefere |
Co-authored-by: Yvonne Fröhlich <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.4.3 to 5.5.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@18283e0...fdcc847) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: 5.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I tried debugging the DVC issue but wasn't successful. I think we'll have to move on for now and revisit it in the future if a fix becomes available. |
This PR improves the
style
parameter (i.e.,-S
option). Previously thestyle
parameter can only acceptl
/n
/u
. Now it can accept more descriptive argumentsstandard
/no_label
/url
.The upstream GMT uses long names
standard
/none
/url
(see https://github.com/GenericMappingTools/gmt/blob/c95470b1c78c412fa15d388be0d9b07de111ba49/src/longopt/gmtlogo_inc.h#L37), but I feelno_label
is more descriptive.Preview: https://pygmt-dev--4074.org.readthedocs.build/en/4074/api/generated/pygmt.Figure.logo.html