Skip to content

Figure: Remove the deprecated _preprocess method (Deprecated since v0.16.0) #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2025
Merged

Figure: Remove the deprecated _preprocess method (Deprecated since v0.16.0) #4146

merged 3 commits into from
Oct 14, 2025

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 9, 2025

Deprecated in PR #3948.

@seisman seisman added this to the 0.18.0 milestone Oct 9, 2025
@seisman seisman added deprecation Deprecating a feature needs review This PR has higher priority and needs review. labels Oct 9, 2025
@seisman seisman force-pushed the deprecate/preprocess branch from 8bb6ee1 to 86715f5 Compare October 9, 2025 03:26
weiji14
weiji14 approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but let's wait another week (until 15 Oct) in case we need to do a patch release for v0.17.0.

@seisman seisman mentioned this pull request Oct 9, 2025
Open
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. final review call This PR requires final review and approval from a second reviewer labels Oct 12, 2025
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Oct 12, 2025
@seisman seisman enabled auto-merge (squash) October 14, 2025 11:42
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 14, 2025
@seisman seisman merged commit a1faeaa into main Oct 14, 2025
23 checks passed
@seisman seisman deleted the deprecate/preprocess branch October 14, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

@yvonnefroehlich yvonnefroehlich yvonnefroehlich approved these changes

Assignees

No one assigned

Labels

deprecation Deprecating a feature

Projects

None yet

Milestone

0.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman @weiji14 @yvonnefroehlich