CI: Fix the slash command "/format" #4158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
/format |
seisman
added
maintenance
weiji14
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Hmm, could have sworn it was working 2 weeks ago (see #4137 (comment)). Ok to merge and test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slash command
/formatdoesn't work as expected becausemake formatreturns a non-zero exit code when files are reformatted. This PR fixes the issue by changingmake formattomake format || true.I can't test the workflow without merging it, because
/formatcan only run the workflow in the main branch not in PRs, butmake format || truereturns zero for me locally.