Prevent reloading timeline after network outage #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is already an automatic reconnect mechanism of the websocket in Connection, there is no need to remove the subscription and empty and reload the timeline after a network outage.
GeopJr
reviewed
Nov 9, 2024
| } | ||
| } | ||
|
|
||
| protected void update_stream () { | ||
| // debug (get_subscriber_name ()+": UPDATED to "+subscribed.to_string ()); | ||
|
|
||
| unsubscribe (); |
There was a problem hiding this comment.
update_stream, as the name implies, is used to update a stream e.g. when you change account, so unsubscribing from the previous one is necessary
|
Thanks for the PR! I added my comments on the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is already an automatic reconnect mechanism of the websocket in Connection, there is no need to remove the subscription and empty and reload the timeline after a network outage.