Dem_s update in connectivity function call #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the hydrological SRTM dem layer (dem_h) with the smoothed raw SRTM dem (dem_s) in our connectivity masking function call. The PR swaps the default value in the function call from dem_h to dem_s and updates the explicit use of the function in the intertidal_workflow notebook.
Both layers handle nodata values differently but I have confirmed that the difference does not impact the outputs in the connectivity masking function (figure 1).
This figure details the resulting connectivity masks, calculated using a) dem_h, b) dem_s (applied as per (a), where nodata values form the starting point for the cost-distance mask), d) dem_s, where 0 m elevations are used as the base of the cost-distance mask and c) the (null) difference between (b) and (d), showing that our code produces the same outcomes, regardless of the nodata or 0 m elevation baseline. Consequently, our extents.load_connectivity_mask function call has not been changed to accommodate the new dem input layer.