Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2 and make python 3.8 be the minimum. #275

Closed
wants to merge 6 commits into from

Conversation

schwehr
Copy link
Contributor

@schwehr schwehr commented Aug 24, 2024

Python 3.7 is end-of-life:

https://devguide.python.org/versions/

https://www.python.org/doc/newstyle/

> New-style classes has been integrated into Python 2.7 and old-style classes has been removed in Python 3.
@schwehr schwehr mentioned this pull request Aug 24, 2024
1 task
This should let me see the workflow run in my work on my fork.
- Still specify the exact python 3.13 as it is not yet released.
  - Updated to release candidate 1. 3.13 release is expected in October 2024.
- Also fix the more information link. The old one one is dead.
@schwehr
Copy link
Contributor Author

schwehr commented Aug 24, 2024

Added a bunch more commits and enabled the build.yml workflow on push so I can see the tests run on my branch. All tests work in my branch.

https://github.com/schwehr/pyshp/commits/drop-py2/

@schwehr
Copy link
Contributor Author

schwehr commented Aug 24, 2024

Removing the patch number of the python versions allowing the workflow to pick newer patch levels of particular python versions, e.g., it was 3.8.18, but now 3.8.19 is being used on my latest commit in my drop-py2 branch:

============================= test session starts ==============================
platform linux -- Python 3.8.19, pytest-8.3.2, pluggy-1.[5](https://github.com/schwehr/pyshp/actions/runs/10539369181/job/29202871229#step:6:6).0

@schwehr
Copy link
Contributor Author

schwehr commented Aug 28, 2024

I'm going to close this PR and split things up differently based on some offline discussions.

@schwehr schwehr closed this Aug 28, 2024
@JamesParrott JamesParrott mentioned this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant