Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] Fix missing languages for 'published' field on Touristic Content in APIv2 (#4439) #4440

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Jan 6, 2025

Description

Related Issue

#4439

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Jan 6, 2025

Geotrek-admin    Run #10788

Run Properties:  status check passed Passed #10788  •  git commit bd09b5179f ℹ️: Merge 06d65b06321ae95b6854eda95c6b447f96b5d8ee into 06f4cd490331b722f248a0ec8931...
Project Geotrek-admin
Branch Review refs/pull/4440/merge
Run status status check passed Passed #10788
Run duration 02m 02s
Commit git commit bd09b5179f ℹ️: Merge 06d65b06321ae95b6854eda95c6b447f96b5d8ee into 06f4cd490331b722f248a0ec8931...
Committer Célia
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (06f4cd4) to head (06d65b0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4440   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         268      268           
  Lines       21362    21365    +3     
=======================================
+ Hits        21035    21038    +3     
  Misses        327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne marked this pull request as ready for review January 9, 2025 09:26
@Chatewgne Chatewgne requested review from a team, justinefricou and submarcos January 9, 2025 09:26
@Chatewgne Chatewgne force-pushed the fix_api_v2_published_touristic_content branch from 3d889a4 to 06d65b0 Compare January 14, 2025 12:43
@Chatewgne Chatewgne merged commit 5a7a989 into master Jan 14, 2025
21 checks passed
@Chatewgne Chatewgne deleted the fix_api_v2_published_touristic_content branch January 14, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants