Skip to content

Conversation

@alexiscott
Copy link
Contributor

@alexiscott alexiscott commented Apr 13, 2021

Hi @dgading this is ready for CR/QA.

I'm figuring that I will want to write some more tests when I add this as a component and can test that It can render. But, do you see a use case for adding more tests here?

@alexiscott alexiscott marked this pull request as draft April 13, 2021 10:12
@alexiscott alexiscott requested a review from dgading April 16, 2021 09:34
@alexiscott alexiscott marked this pull request as ready for review April 16, 2021 09:39
@alexiscott alexiscott linked an issue Apr 16, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit link for logged in user on dataset page

2 participants