Creation of Localizable file and implementation of Japanese version #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Localizableファイルの作成と日本語版の実装
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw your application on the App Store. This app is very useful to check the movement of the animation.
I have implemented the following so that more people can make use of this app.
Implementation Details)
This is the main feature of this pull request. This will allow developers to localize this app into their respective languages by simply creating a Localizable file.
Japanese speakers will be able to easily manipulate this application; please use this as a sample description of a Localizable file.
Parts not to be implemented)
Pop-up display when copied to clipboard
-> It needs to be implemented in such a way that the size is not overlooked because the number of characters varies depending on the language. However, I could not think of a good way to do this, so I put it on hold.
Concern)
We have made every effort to ensure that the Japanese translation is as natural and nuanced as possible, but there are a few areas of uncertainty.
I know this is your first pull request and there are some things that may not be good, but please respond. Contact information is provided below.
Contact)
Email : [email protected]