[AND-209] Revert public api changes. #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
🛠 Implementation details
commonMain
toandroidMain
to utilise Android specific classes (Context
,FirebaseMessaging
)PushDeviceGenerator
suspend fun generatePushDevice
tofun asyncGeneratePushDevice
isValidForThisDevice
lambda from thePushDeviceGenerator
s constructors, and put the checks in their ownisValidForThisDevice
methodsFirebaseMessagingDelegate
fromhandleRemoteMessage(StreamRemoteMessage)
tohandleRemoteMessage(RemoteMessage)
PushDeviceGenerator
isValidForThisDevice(Context)
method is no longer possible, asstream-android-push
is KMP, and we cannot accessContext
there. Therefore, instead of passingContext
to theisValidForThisDevice
method, we need to pass it as contractor param to the implementations of thePushDeviceGenerator
. This is relevant forFirebasePushDeviceGenerator
,Huawei/Xiaomi
already acceptedContext
via their constructors.