Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBE-0] Fix UI tests. #5467

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[PBE-0] Fix UI tests. #5467

merged 1 commit into from
Nov 11, 2024

Conversation

VelikovPetar
Copy link
Contributor

🎯 Goal

Couple of UI tests in stream-chat-android-ui-uitests were not compiling, and a couple of them were failing. This caused some of the GH actions to fail as well.

🛠 Implementation details

  • Fix compilation errors by adding default value for: MessageList - onAddAnswer
  • Fix compilation errors by adding missing typingUsers for ChannelItemState in the tests
  • Add mandatory polls field to the mock http_channels.json response

🧪 Testing

  • Run all UI tests in the stream-chat-android-ui-uitests

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@VelikovPetar VelikovPetar requested a review from a team as a code owner November 7, 2024 11:46
@JcMinarro JcMinarro enabled auto-merge (rebase) November 11, 2024 15:46
@JcMinarro JcMinarro merged commit 101c0f0 into develop Nov 11, 2024
7 checks passed
@JcMinarro JcMinarro deleted the bug/fix_ui_tests branch November 11, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants