Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-403] Fix "Thread reply" enabled while in thread. #5683

Merged
merged 8 commits into from
Mar 27, 2025

Conversation

VelikovPetar
Copy link
Contributor

@VelikovPetar VelikovPetar commented Mar 18, 2025

🎯 Goal

The "Thread reply" item was wrongly shown as a message option when opening the menu inside a thread.

🛠 Implementation details

  • Add the missing check for isInThread in the capability check logic.
  • Change the capability check from QUOTE_MESSAGE to SEND_REPLY

🎨 UI Changes

Before After
before.mp4
after.mp4

🧪 Testing

  1. Open a channel
  2. Open a thread
  3. Long press on a message from the thread
  4. The "Thread reply" item should not be visible

Copy link
Contributor

github-actions bot commented Mar 18, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.18 MB 3.18 MB 0.00 MB 🟢
stream-chat-android-offline 3.39 MB 3.39 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.89 MB 7.89 MB 0.00 MB 🟢
stream-chat-android-compose 9.92 MB 9.92 MB 0.00 MB 🟢

@VelikovPetar VelikovPetar changed the title Fix "Thread reply" enabled while in thread. [AND-403] Fix "Thread reply" enabled while in thread. Mar 18, 2025
@VelikovPetar VelikovPetar marked this pull request as ready for review March 18, 2025 12:37
@VelikovPetar VelikovPetar requested a review from a team as a code owner March 18, 2025 12:37
@andremion andremion self-requested a review March 19, 2025 15:14
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
68.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@VelikovPetar VelikovPetar merged commit 4866734 into develop Mar 27, 2025
13 of 14 checks passed
@VelikovPetar VelikovPetar deleted the bug/fix_thread_reply_enabled_while_in_thread branch March 27, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants