[AND-401] Fix audio recordings not paused #5685
Open
+371
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size Comparison 📏
|
VelikovPetar
changed the title
JcMinarro
reviewed
Mar 24, 2025
Comment on lines
238
to
239
| val audioPlayer = ChatClient.instance().audioPlayer | ||
| audioPlayer.pause() |
There was a problem hiding this comment.
Our UI should't use the ChatClient itself.
Could we move this logic to the ViewModel?
There was a problem hiding this comment.
I will try to re-wire it to go through the VM.
JcMinarro
reviewed
Mar 24, 2025
Comment on lines
651
to
655
| private val pauseAudioPlayerListener = object : DefaultLifecycleObserver { | ||
| override fun onPause(owner: LifecycleOwner) { | ||
| ChatClient.instance().audioPlayer.pause() | ||
| } | ||
| } |
There was a problem hiding this comment.
The same case here, ChatClient shouldn't be used within our UI
added 3 commits
March 24, 2025 11:51
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
A playing audio recording attachment in the Message List is not paused/stopped in the following scenarios:
🛠 Implementation details
ui-commonaudioHashis created for both XML and Compose SDKs. On the XML SDK, theaudioHashwas generated asAttachment::hashCode, while on the Compose SDK theaudioHashwas generated as(attachment.assetUrl ?: attachment.upload?.toUri()?.toString()).hashCode(). This is now unified in theAttachment::audioHashextension, and the same is used in both SDK. This is needed for the change inMessageListController:chatClient.deleteMessage(), in theMessageListController, we check if the deleted message has a playing audio recording -> by comparing thechatClient.audioPlayer.currentPlayingIdwith themessage.attachment.audioHash. If the message currently being deleted has a playing audio, pause it before launching delete request.ui-componentsLifecycleObserverin the audio recording attachment view holder, which will pause any running audio inonPause.MessageListView, to handle the case when the audio recording viewHolder is recycled (when scrolling away) which causes the item-level observer to be removed.MessageListViewobserver is enough to fix the bug, but I added the one on the Item for the case when a customer would use theMediaAttachmentsViewHolderindependently form theMessageListViewcomposeLifecycleEventEffectinAudioRecordAttachmentContentandAudioRecordAttachmentPreviewContent, which pause any running audio inonPause.MessageList, to handle the case when the audio recording item composable is disposed (when scrolling away) which causes the item-level effect to be removed.MessageListViewobserver is enough to fix the bug, but I added the one on the Item for the case when a customer would use theAudioRecordAttachmentContentindependently form theMessageList🎨 UI Changes
compose-before.mp4
compose-after.mp4
xml-before.mp4
xml-after.mp4
🧪 Testing