[AND-411] Emphasize the selected list item in ChatsScreen on wide screens #5686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andremion
changed the title
andremion
changed the title
andremion
changed the title
SDK Size Comparison 📏
|
andremion
force-pushed
the
AND-388-render-pinned-messages-in-info-pane
branch
from
fd5dd8a to
10f5d82
Compare
Base automatically changed from
AND-388-render-pinned-messages-in-info-pane
to
develop
March 21, 2025 12:50
…nd compponent factories
andremion
force-pushed
the
AND-411-emphasize-the-selected-list-item
branch
from
770f009 to
49c0419
Compare
JcMinarro
approved these changes
Mar 24, 2025
...android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/EmphasisBox.kt
Show resolved
Hide resolved
...m-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/ChatTheme.kt
Show resolved
Hide resolved
|
VelikovPetar
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Emphasize the selected items in ChatsScreen when rendering on wide screens
🛠 Implementation details
A small refactoring had to be done to support emphasizing the items.
LocalComponentFactoryis now public, so we can compound component factories more easily than customizing components using their parameters. In fact, none of them should be read-only. The concept of Compose local composition is to allow consumers to provide a new composition locally.Also, the lazy list IDs for channels, topics, and messages have been revised.
🎨 UI Changes
list.item.emphasis.tablet.webm
🧪 Testing
🎉 GIF