-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AND-406] Draft Messages on UI Components #5687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size Comparison 📏
|
6c75766
to
9425b6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left couple of remarks/questions, but looks very good! GJ!
...n/io/getstream/chat/android/ui/common/feature/messages/composer/MessageComposerController.kt
Outdated
Show resolved
Hide resolved
...n/io/getstream/chat/android/ui/common/feature/messages/composer/MessageComposerController.kt
Outdated
Show resolved
Hide resolved
stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt
Show resolved
Hide resolved
...rc/main/java/io/getstream/chat/android/compose/viewmodel/channels/ChannelViewModelFactory.kt
Show resolved
Hide resolved
...n/io/getstream/chat/android/ui/common/feature/messages/composer/MessageComposerController.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/io/getstream/chat/android/ui/viewmodel/channels/ChannelListViewModelFactory.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/io/getstream/chat/android/ui/viewmodel/messages/MessageListViewModelFactory.kt
Outdated
Show resolved
Hide resolved
9425b6f
to
c836715
Compare
VelikovPetar
approved these changes
Mar 27, 2025
0693db5
to
e365740
Compare
|
LGTM! ✅ The only comment is that the Offline Support is out of scope for this PR. Let's implement it in a separate one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Depend on: #5682
With this implementation show draft messages within the list of channels and message composer.
🎨 UI Changes
xml-draft-message.mp4
compose-draft-messages.mp4
🧪 Testing
To test it you will need to enable draft messages feature on Channels List and Message Composer.
The following patch add the needed flags
Provide the patch summary here