Skip to content

feat(ui, localization): Add confirmation dialog for end vote in Polls #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025

Conversation

xsahil03x
Copy link
Member

Fixes: #2211

Description of the pull request

This pull request adds a confirmation dialog for end vote in Polls.

Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 94.54545% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.08%. Comparing base (8a3513c) to head (5e6790a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...t_flutter/lib/src/message_widget/poll_message.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2237      +/-   ##
==========================================
+ Coverage   63.00%   63.08%   +0.07%     
==========================================
  Files         400      401       +1     
  Lines       25155    25209      +54     
==========================================
+ Hits        15849    15903      +54     
  Misses       9306     9306              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xsahil03x xsahil03x force-pushed the feat/ask-confirmation-for-closing-poll branch from 4a75dfd to 5e6790a Compare May 5, 2025 22:02
@xsahil03x xsahil03x merged commit 3c3dd16 into master May 6, 2025
16 checks passed
@xsahil03x xsahil03x deleted the feat/ask-confirmation-for-closing-poll branch May 6, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants