Skip to content

fix: audio recording race condition#3430

Merged
isekovanic merged 5 commits intodevelopfrom
fix/audio-recording-race-condition
Feb 25, 2026
Merged

fix: audio recording race condition#3430
isekovanic merged 5 commits intodevelopfrom
fix/audio-recording-race-condition

Conversation

@isekovanic
Copy link
Contributor

🎯 Goal

This PR addresses an issue with voice recording, where if we let go of the long press gesture just after onLongPress has fired, but before startRecording has actually been invoked, we would get the player stuck in a bad state where we would neither be able to cancel nor lock the microphone in unless we long press again (which is not really intuitive).

We implement a simple locking/semaphore mechanism to make sure this does not happen.

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@Stream-SDK-Bot
Copy link
Contributor

Stream-SDK-Bot commented Feb 25, 2026

SDK Size

title develop branch diff status
js_bundle_size 424 KB 425 KB +877 B 🔴

@isekovanic isekovanic merged commit 4ff7714 into develop Feb 25, 2026
4 of 5 checks passed
@isekovanic isekovanic deleted the fix/audio-recording-race-condition branch February 25, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants