-
Notifications
You must be signed in to change notification settings - Fork 225
Fix demo app swiftformat #3769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix demo app swiftformat #3769
Conversation
WalkthroughThis change set makes minor code style and access control adjustments in two files related to the livestream chat and reactions UI. It removes an unnecessary return and a trailing space in a closure and guard statement, and restricts the access of a UI struct from fileprivate to private. No functional or behavioral changes are introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
DemoApp/Screens/Livestream/DemoLivestreamChatMessageListVC.swift (1)
36-40
: Redundantreturn
removed – consider explicitCGFloat
literalThe implicit return cleans the closure nicely. As a tiny readability nit, you could make the numeric literal explicitly a
CGFloat
:- .custom { _ in - 180 + .custom { _ in + CGFloat(180) }This avoids the literal starting life as an
Int
and relying on implicit conversion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
DemoApp/Screens/Livestream/DemoLivestreamChatMessageListVC.swift
(2 hunks)DemoApp/Screens/Livestream/DemoLivestreamReactionsListView.swift
(1 hunks)
🔇 Additional comments (2)
DemoApp/Screens/Livestream/DemoLivestreamReactionsListView.swift (1)
110-110
: Encapsulation tightened — looks goodChanging
ReactionRowView
fromfileprivate
toprivate
keeps the type restricted to this file while slightly reducing its accidental exposure surface. No behavioural impact and no follow-up required.DemoApp/Screens/Livestream/DemoLivestreamChatMessageListVC.swift (1)
50-51
: Trailing-space cleanup acknowledgedWhitespace tidy-up only; no functional change.
🎯 Goal
Quickly fix formatting issues on the demo app
Summary by CodeRabbit
Style
Refactor