Skip to content

Fix demo app swiftformat #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Fix demo app swiftformat #3769

merged 1 commit into from
Aug 6, 2025

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Aug 6, 2025

🎯 Goal

Quickly fix formatting issues on the demo app

Summary by CodeRabbit

  • Style

    • Minor code style improvements for consistency and readability in the livestream chat and reactions screens.
  • Refactor

    • Adjusted access level of an internal component for improved encapsulation.

@nuno-vieira nuno-vieira requested a review from a team as a code owner August 6, 2025 09:30
Copy link

coderabbitai bot commented Aug 6, 2025

Walkthrough

This change set makes minor code style and access control adjustments in two files related to the livestream chat and reactions UI. It removes an unnecessary return and a trailing space in a closure and guard statement, and restricts the access of a UI struct from fileprivate to private. No functional or behavioral changes are introduced.

Changes

Cohort / File(s) Change Summary
Livestream Chat Message List Style Cleanups
DemoApp/Screens/Livestream/DemoLivestreamChatMessageListVC.swift
Removed explicit return in a single-line closure and eliminated a trailing space after guard. No functional changes.
Livestream Reactions View Access Restriction
DemoApp/Screens/Livestream/DemoLivestreamReactionsListView.swift
Changed ReactionRowView struct's access modifier from fileprivate to private.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny hopped through code so neat,
Tidied closures, made them sweet.
Guarded spaces trimmed with care,
Access private—none to spare.
No bugs to chase, no flows to mend,
Just gentle tweaks from end to end.
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/demo-app-swift-format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
DemoApp/Screens/Livestream/DemoLivestreamChatMessageListVC.swift (1)

36-40: Redundant return removed – consider explicit CGFloat literal

The implicit return cleans the closure nicely. As a tiny readability nit, you could make the numeric literal explicitly a CGFloat:

-                    .custom { _ in
-                        180
+                    .custom { _ in
+                        CGFloat(180)
                     }

This avoids the literal starting life as an Int and relying on implicit conversion.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e84e41f and c2c20ab.

📒 Files selected for processing (2)
  • DemoApp/Screens/Livestream/DemoLivestreamChatMessageListVC.swift (2 hunks)
  • DemoApp/Screens/Livestream/DemoLivestreamReactionsListView.swift (1 hunks)
🔇 Additional comments (2)
DemoApp/Screens/Livestream/DemoLivestreamReactionsListView.swift (1)

110-110: Encapsulation tightened — looks good

Changing ReactionRowView from fileprivate to private keeps the type restricted to this file while slightly reducing its accidental exposure surface. No behavioural impact and no follow-up required.

DemoApp/Screens/Livestream/DemoLivestreamChatMessageListVC.swift (1)

50-51: Trailing-space cleanup acknowledged

Whitespace tidy-up only; no functional change.

@nuno-vieira nuno-vieira merged commit b45b50e into develop Aug 6, 2025
12 checks passed
@nuno-vieira nuno-vieira deleted the fix/demo-app-swift-format branch August 6, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant