[V5] Replace StreamCollection and LazyCachedMapCollection with Array #3830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SDK Size
|
SDK Performance
|
Generated by 🚫 Danger |
laevandus
force-pushed
the
v5-remove-stream-collection-lazy-cached-map-collection
branch
from
394c731 to
8bd4e6d
Compare
SDK Size
|
laevandus
force-pushed
the
v5-remove-stream-collection-lazy-cached-map-collection
branch
3 times, most recently
from
c6262e1 to
90b2eae
Compare
Public Interface- public struct StreamCollection: RandomAccessCollection
-
- public var startIndex: Index
- public var endIndex: Index
-
-
- public subscript(position: Index)-> Element
-
-
- public init(_ baseCollection: BaseCollection)
- extension LazyCachedMapCollection: Equatable
-
- public static func ==(lhs: LazyCachedMapCollection<Element>,rhs: LazyCachedMapCollection<Element>)-> Bool
- public struct LazyCachedMapCollection: RandomAccessCollection
-
- public var startIndex: Index
- public var endIndex: Index
- public var count: Index
-
-
- public subscript(position: Index)-> Element
-
-
- public init(_ collection: LazyCachedMapCollection)
- public init(source: Collection,map: @escaping (SourceElement) -> Element,context: NSManagedObjectContext? = nil)
-
-
- public func index(before i: Index)-> Index
- public func index(after i: Index)-> Index
- public mutating func append(_ element: Element)
- extension RandomAccessCollection
-
- public func lazyCachedMap(_ transformation: @escaping (Element) -> T,context: NSManagedObjectContext? = nil)-> LazyCachedMapCollection<T>
- extension StreamCollection: CustomStringConvertible
-
- public var description: String
public class PollController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var ownVotes: LazyCachedMapCollection<PollVote>
+ public var ownVotes: [PollVote]
public class PollVoteListController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var votes: LazyCachedMapCollection<PollVote>
+ public var votes: [PollVote]
@MainActor public final class ReactionListState: ObservableObject
- @Published public private var reactions
+ @Published public private var reactions: [ChatMessageReaction]
@MainActor public final class ChatState: ObservableObject
- @Published public private var members
+ @Published public private var members: [ChatChannelMember]
- @Published public internal var messages
+ @Published public internal var messages: [ChatMessage]
- @Published public internal var watchers
+ @Published public internal var watchers: [ChatUser]
@MainActor public final class MemberListState: ObservableObject
- @Published public private var members
+ @Published public private var members: [ChatChannelMember]
public class ChatChannelMemberListController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var members: LazyCachedMapCollection<ChatChannelMember>
+ public var members: [ChatChannelMember]
public class ChatUserListController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var users: LazyCachedMapCollection<ChatUser>
+ public var users: [ChatUser]
@MainActor public final class MessageSearchState: ObservableObject
- @Published public internal var messages
+ @Published public internal var messages: [ChatMessage]
public class ChatMessageController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var replies: LazyCachedMapCollection<ChatMessage>
+ public var replies: [ChatMessage]
public class ChatThreadListController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var threads: LazyCachedMapCollection<ChatThread>
+ public var threads: [ChatThread]
@MainActor public final class MessageState: ObservableObject
- @Published public private var reactions
+ @Published public private var reactions: [ChatMessageReaction]
- @Published public internal var replies
+ @Published public internal var replies: [ChatMessage]
public class ChatChannelController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var messages: LazyCachedMapCollection<ChatMessage>
+ public var messages: [ChatMessage]
@MainActor public final class UserListState: ObservableObject
- @Published public private var users
+ @Published public private var users: [ChatUser]
public class ChatChannelWatcherListController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var watchers: LazyCachedMapCollection<ChatUser>
+ public var watchers: [ChatUser]
public class ChatChannelListController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var channels: LazyCachedMapCollection<ChatChannel>
+ public var channels: [ChatChannel]
extension PollController
- @Published public private var ownVotes: LazyCachedMapCollection<PollVote>
+ @Published public private var ownVotes: [PollVote]
public class ChatReactionListController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var reactions: LazyCachedMapCollection<ChatMessageReaction>
+ public var reactions: [ChatMessageReaction]
@MainActor public final class ChannelListState: ObservableObject
- @Published public internal var channels
+ @Published public internal var channels: [ChatChannel]
extension PollVoteListController
- @Published public private var votes: LazyCachedMapCollection<PollVote>
+ @Published public private var votes: [PollVote]
public class ChatMessageSearchController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var messages: LazyCachedMapCollection<ChatMessage>
+ public var messages: [ChatMessage]
@MainActor public final class UserSearchState: ObservableObject
- @Published public internal var users
+ @Published public internal var users: [ChatUser]
public class MessageReminderListController: DataController, DelegateCallable, DataStoreProvider, @unchecked Sendable
- public var reminders: LazyCachedMapCollection<MessageReminder>
+ public var reminders: [MessageReminder] |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Related: IOS-1003
🎯 Goal
StreamCollectionandLazyCachedMapCollectiondo not add any value anymore☑️ Contributor Checklist
docs-contentrepo