Skip to content

V5: message list attachments redesign #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laevandus merged 30 commits into from
Mar 6, 2026

Tidy text view

c58fa00
Select commit
Loading
Failed to load commit list.
Merged

V5: message list attachments redesign #1264

Tidy text view
c58fa00
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 5, 2026 in 5m 29s

Quality Gate failed

Failed conditions
1 Security Hotspot
77.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 55 in Sources/StreamChatSwiftUI/ChatMessageList/WebView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "webView" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsR3gE9ChFi-UZ40&open=AZy5WsR3gE9ChFi-UZ40&pullRequest=1264

Check warning on line 154 in Sources/StreamChatSwiftUI/ChatMessageList/AsyncVoiceMessages/WaveformView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "context" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsS4gE9ChFi-UZ4_&open=AZy5WsS4gE9ChFi-UZ4_&pullRequest=1264

Check warning on line 152 in Sources/StreamChatSwiftUI/ChatComposer/AttachmentPicker/AttachmentCameraPickerView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "context" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsZNgE9ChFi-UZ5v&open=AZy5WsZNgE9ChFi-UZ5v&pullRequest=1264

Check warning on line 312 in Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/EditGroupView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "picker" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy-FIEO4PF7cDTLhfCK&open=AZy-FIEO4PF7cDTLhfCK&pullRequest=1264

Check warning on line 125 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/MessageActions/DefaultMessageActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the nested one. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsMIgE9ChFi-UZ4Q&open=AZy5WsMIgE9ChFi-UZ4Q&pullRequest=1264

Check warning on line 242 in Sources/StreamChatSwiftUI/ChatMessageList/AsyncVoiceMessages/VoiceRecordingContainerView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "audioPlayer" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsSdgE9ChFi-UZ48&open=AZy5WsSdgE9ChFi-UZ48&pullRequest=1264

Check warning on line 165 in Sources/StreamChatSwiftUI/ChatMessageList/GiphyAttachmentView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "uiView" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsTZgE9ChFi-UZ5C&open=AZy5WsTZgE9ChFi-UZ5C&pullRequest=1264

Check warning on line 228 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/ReactionsOverlayView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "reader" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsLYgE9ChFi-UZ4N&open=AZy5WsLYgE9ChFi-UZ4N&pullRequest=1264

Check failure on line 245 in Sources/StreamChatSwiftUI/Styles.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WskfgE9ChFi-UZ6k&open=AZy5WskfgE9ChFi-UZ6k&pullRequest=1264

Check warning on line 29 in Sources/StreamChatSwiftUI/Utils/Common/Compatibility+TaskViewModifier.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5Wsg_gE9ChFi-UZ6P&open=AZy5Wsg_gE9ChFi-UZ6P&pullRequest=1264

Check warning on line 690 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/MessageActions/DefaultMessageActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "channel" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsMIgE9ChFi-UZ4Z&open=AZy5WsMIgE9ChFi-UZ4Z&pullRequest=1264

Check warning on line 49 in Sources/StreamChatSwiftUI/ChatMessageList/Gallery/ShareButtonView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "uiViewController" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsP1gE9ChFi-UZ4n&open=AZy5WsP1gE9ChFi-UZ4n&pullRequest=1264

Check warning on line 663 in Sources/StreamChatSwiftUI/ViewFactory/DefaultViewFactory.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "options" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5Wr8PgE9ChFi-UZ4H&open=AZy5Wr8PgE9ChFi-UZ4H&pullRequest=1264

Check warning on line 161 in Sources/StreamChatSwiftUI/ChatMessageList/MessageRepliesView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "change" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsU7gE9ChFi-UZ5K&open=AZy5WsU7gE9ChFi-UZ5K&pullRequest=1264

Check warning on line 138 in Sources/StreamChatSwiftUI/ChatMessageList/MessageItemView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsRPgE9ChFi-UZ4v&open=AZy5WsRPgE9ChFi-UZ4v&pullRequest=1264

Check warning on line 109 in Sources/StreamChatSwiftUI/ChatChannelList/DefaultChannelActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsizgE9ChFi-UZ6T&open=AZy5WsizgE9ChFi-UZ6T&pullRequest=1264

Check warning on line 421 in Sources/StreamChatSwiftUI/ChatMessageList/MessageListView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "index" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsUDgE9ChFi-UZ5F&open=AZy5WsUDgE9ChFi-UZ5F&pullRequest=1264

Check failure on line 263 in Sources/StreamChatSwiftUI/Styles.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WskfgE9ChFi-UZ6l&open=AZy5WskfgE9ChFi-UZ6l&pullRequest=1264

Check warning on line 45 in Sources/StreamChatSwiftUI/ChatComposer/AttachmentPicker/AttachmentMediaPicker/PhotoAssetLoader.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "switch" statement with "if" statement to increase readability. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsZtgE9ChFi-UZ5y&open=AZy5WsZtgE9ChFi-UZ5y&pullRequest=1264

Check failure on line 90 in Sources/StreamChatSwiftUI/ChatComposer/AttachmentPicker/AttachmentMediaPicker/AttachmentMediaPickerView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsZ9gE9ChFi-UZ5z&open=AZy5WsZ9gE9ChFi-UZ5z&pullRequest=1264

Check warning on line 303 in Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/EditGroupView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "picker" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy-FIEO4PF7cDTLhfCJ&open=AZy-FIEO4PF7cDTLhfCJ&pullRequest=1264

Check warning on line 168 in Sources/StreamChatSwiftUI/ChatComposer/AttachmentPicker/AttachmentCameraPickerView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "picker" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsZNgE9ChFi-UZ5w&open=AZy5WsZNgE9ChFi-UZ5w&pullRequest=1264

Check warning on line 38 in Sources/StreamChatSwiftUI/CommonViews/Avatars/UserAvatar.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5Wse3gE9ChFi-UZ6L&open=AZy5Wse3gE9ChFi-UZ6L&pullRequest=1264

Check warning on line 116 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/ReactionsDetailViewModel.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "controller" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsKggE9ChFi-UZ4K&open=AZy5WsKggE9ChFi-UZ4K&pullRequest=1264

Check warning on line 109 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/ReactionsDetailViewModel.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "change" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsKggE9ChFi-UZ4J&open=AZy5WsKggE9ChFi-UZ4J&pullRequest=1264
View more details on SonarQubeCloud