Skip to content

V5: message list attachments redesign #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laevandus merged 30 commits into from
Mar 6, 2026

Fix e2e tests

0237de7
Select commit
Loading
Failed to load commit list.
Merged

V5: message list attachments redesign #1264

Fix e2e tests
0237de7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 6, 2026 in 4m 30s

Quality Gate failed

Failed conditions
1 Security Hotspot
78.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 55 in Sources/StreamChatSwiftUI/ChatMessageList/WebView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "webView" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsR3gE9ChFi-UZ40&open=AZy5WsR3gE9ChFi-UZ40&pullRequest=1264

Check warning on line 45 in Sources/StreamChatSwiftUI/ChatComposer/AttachmentPicker/AttachmentMediaPicker/PhotoAssetLoader.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "switch" statement with "if" statement to increase readability. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsZtgE9ChFi-UZ5y&open=AZy5WsZtgE9ChFi-UZ5y&pullRequest=1264

Check failure on line 65 in Sources/StreamChatSwiftUI/ChatComposer/Buttons/SendMessageButton.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this closure is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsbFgE9ChFi-UZ58&open=AZy5WsbFgE9ChFi-UZ58&pullRequest=1264

Check warning on line 275 in Sources/StreamChatSwiftUI/ChatMessageList/AsyncVoiceMessages/WaveformView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "context" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsS4gE9ChFi-UZ4_&open=AZy5WsS4gE9ChFi-UZ4_&pullRequest=1264

Check warning on line 143 in Sources/StreamChatSwiftUI/Styles.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "options" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WskfgE9ChFi-UZ6b&open=AZy5WskfgE9ChFi-UZ6b&pullRequest=1264

Check warning on line 312 in Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/EditGroupView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "picker" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy-FIEO4PF7cDTLhfCK&open=AZy-FIEO4PF7cDTLhfCK&pullRequest=1264

Check warning on line 64 in Sources/StreamChatSwiftUI/ChatMessageList/Gallery/ZoomableScrollView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "coder" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsQRgE9ChFi-UZ4q&open=AZy5WsQRgE9ChFi-UZ4q&pullRequest=1264

Check warning on line 63 in Sources/StreamChatSwiftUI/ChatComposer/Suggestions/CommandsConfig.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor your code to get this URI from a customizable parameter. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsXzgE9ChFi-UZ5l&open=AZy5WsXzgE9ChFi-UZ5l&pullRequest=1264

Check warning on line 134 in Sources/StreamChatSwiftUI/ChatComposer/Suggestions/Commands/TwoStepMentionCommand.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "completion" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsXcgE9ChFi-UZ5i&open=AZy5WsXcgE9ChFi-UZ5i&pullRequest=1264

Check warning on line 125 in Sources/StreamChatSwiftUI/ChatComposer/Suggestions/CommandsHandler.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor your code to get this URI from a customizable parameter. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsYrgE9ChFi-UZ5q&open=AZy5WsYrgE9ChFi-UZ5q&pullRequest=1264

Check warning on line 421 in Sources/StreamChatSwiftUI/ChatMessageList/MessageListView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "message" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsUDgE9ChFi-UZ5G&open=AZy5WsUDgE9ChFi-UZ5G&pullRequest=1264

Check failure on line 22 in Sources/StreamChatSwiftUI/Utils/MessageRemindersFormatter.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WshugE9ChFi-UZ6Q&open=AZy5WshugE9ChFi-UZ6Q&pullRequest=1264

Check warning on line 33 in Sources/StreamChatSwiftUI/ChatMessageList/WebView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "context" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsR3gE9ChFi-UZ4y&open=AZy5WsR3gE9ChFi-UZ4y&pullRequest=1264

Check warning on line 48 in Sources/StreamChatSwiftUI/ChatComposer/Suggestions/CommandsConfig.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor your code to get this URI from a customizable parameter. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsXzgE9ChFi-UZ5j&open=AZy5WsXzgE9ChFi-UZ5j&pullRequest=1264

Check warning on line 653 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/MessageActions/DefaultMessageActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "channel" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsMIgE9ChFi-UZ4Y&open=AZy5WsMIgE9ChFi-UZ4Y&pullRequest=1264

Check warning on line 291 in Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/EditGroupView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "uiViewController" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy-FIEO4PF7cDTLhfCH&open=AZy-FIEO4PF7cDTLhfCH&pullRequest=1264

Check warning on line 26 in Sources/StreamChatSwiftUI/ChatComposer/Suggestions/Commands/TwoStepMentionCommand.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "commandSymbol" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsXcgE9ChFi-UZ5f&open=AZy5WsXcgE9ChFi-UZ5f&pullRequest=1264

Check warning on line 390 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/MessageActions/DefaultMessageActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "channel" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsMIgE9ChFi-UZ4U&open=AZy5WsMIgE9ChFi-UZ4U&pullRequest=1264

Check warning on line 765 in Sources/StreamChatSwiftUI/ChatComposer/MessageComposerViewModel.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor your code to get this URI from a customizable parameter. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsbxgE9ChFi-UZ5-&open=AZy5WsbxgE9ChFi-UZ5-&pullRequest=1264

Check warning on line 690 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/MessageActions/DefaultMessageActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "channel" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsMIgE9ChFi-UZ4Z&open=AZy5WsMIgE9ChFi-UZ4Z&pullRequest=1264

Check warning on line 139 in Sources/StreamChatSwiftUI/Styles.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "options" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WskfgE9ChFi-UZ6a&open=AZy5WskfgE9ChFi-UZ6a&pullRequest=1264

Check warning on line 138 in Sources/StreamChatSwiftUI/ChatMessageList/MessageItemView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsRPgE9ChFi-UZ4v&open=AZy5WsRPgE9ChFi-UZ4v&pullRequest=1264

Check failure on line 124 in Sources/StreamChatSwiftUI/ChatMessageList/MessageListView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this closure is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsUDgE9ChFi-UZ5E&open=AZy5WsUDgE9ChFi-UZ5E&pullRequest=1264

Check warning on line 217 in Sources/StreamChatSwiftUI/ChatMessageList/FileAttachmentView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "context" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsVVgE9ChFi-UZ5P&open=AZy5WsVVgE9ChFi-UZ5P&pullRequest=1264

Check warning on line 92 in Sources/StreamChatSwiftUI/ChatComposer/AttachmentPicker/AttachmentFilePickerView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "controller" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsaPgE9ChFi-UZ52&open=AZy5WsaPgE9ChFi-UZ52&pullRequest=1264
View more details on SonarQubeCloud