Skip to content

V5: message list attachments redesign #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laevandus merged 30 commits into from
Mar 6, 2026

[CI] Snapshots (#1271)

c1f07af
Select commit
Loading
Failed to load commit list.
Merged

V5: message list attachments redesign #1264

[CI] Snapshots (#1271)
c1f07af
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 6, 2026 in 5m 20s

Quality Gate failed

Failed conditions
1 Security Hotspot
78.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 77 in Sources/StreamChatSwiftUI/ChatComposer/AttachmentPicker/AttachmentFilePickerView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "uiViewController" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsaPgE9ChFi-UZ50&open=AZy5WsaPgE9ChFi-UZ50&pullRequest=1264

Check warning on line 39 in Sources/StreamChatSwiftUI/ChatComposer/Suggestions/Commands/UnmuteCommandHandler.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant return. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsWngE9ChFi-UZ5W&open=AZy5WsWngE9ChFi-UZ5W&pullRequest=1264

Check failure on line 217 in Sources/StreamChatSwiftUI/ChatMessageList/FileAttachmentView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsVVgE9ChFi-UZ5N&open=AZy5WsVVgE9ChFi-UZ5N&pullRequest=1264

Check warning on line 65 in Sources/StreamChatSwiftUI/ChatMessageList/Polls/PollOptionAllVotesViewModel.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "changes" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsPAgE9ChFi-UZ4i&open=AZy5WsPAgE9ChFi-UZ4i&pullRequest=1264

Check warning on line 232 in Sources/StreamChatSwiftUI/ChatMessageList/AsyncVoiceMessages/WaveformView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "context" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZzCfVahg5NaVDf9ygRz&open=AZzCfVahg5NaVDf9ygRz&pullRequest=1264

Check warning on line 39 in Sources/StreamChatSwiftUI/ChatComposer/Suggestions/Commands/MuteCommandHandler.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant return. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsWTgE9ChFi-UZ5T&open=AZy5WsWTgE9ChFi-UZ5T&pullRequest=1264

Check warning on line 64 in Sources/StreamChatSwiftUI/ChatMessageList/Gallery/ZoomableScrollView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "coder" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsQRgE9ChFi-UZ4q&open=AZy5WsQRgE9ChFi-UZ4q&pullRequest=1264

Check warning on line 138 in Sources/StreamChatSwiftUI/ChatMessageList/MessageItemView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsRPgE9ChFi-UZ4v&open=AZy5WsRPgE9ChFi-UZ4v&pullRequest=1264

Check warning on line 84 in Sources/StreamChatSwiftUI/ChatMessageList/WebView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "navigation" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsR3gE9ChFi-UZ46&open=AZy5WsR3gE9ChFi-UZ46&pullRequest=1264

Check warning on line 26 in Sources/StreamChatSwiftUI/ChatComposer/MessageComposerViewModel+Recording.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "audioRecorder" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WscSgE9ChFi-UZ6A&open=AZy5WscSgE9ChFi-UZ6A&pullRequest=1264

Check warning on line 421 in Sources/StreamChatSwiftUI/ChatMessageList/MessageListView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "index" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsUDgE9ChFi-UZ5F&open=AZy5WsUDgE9ChFi-UZ5F&pullRequest=1264

Check failure on line 60 in Sources/StreamChatSwiftUI/ChatComposer/Buttons/SendMessageButton.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this closure is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsbFgE9ChFi-UZ57&open=AZy5WsbFgE9ChFi-UZ57&pullRequest=1264

Check failure on line 291 in Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/EditGroupView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy-FIEO4PF7cDTLhfCG&open=AZy-FIEO4PF7cDTLhfCG&pullRequest=1264

Check warning on line 121 in Sources/StreamChatSwiftUI/Styles.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "options" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WskfgE9ChFi-UZ6Z&open=AZy5WskfgE9ChFi-UZ6Z&pullRequest=1264

Check warning on line 365 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/MessageActions/DefaultMessageActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "channel" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsMIgE9ChFi-UZ4T&open=AZy5WsMIgE9ChFi-UZ4T&pullRequest=1264

Check warning on line 506 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/MessageActions/DefaultMessageActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "chatClient" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsMIgE9ChFi-UZ4V&open=AZy5WsMIgE9ChFi-UZ4V&pullRequest=1264

Check failure on line 22 in Sources/StreamChatSwiftUI/Utils/MessageRemindersFormatter.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WshugE9ChFi-UZ6Q&open=AZy5WshugE9ChFi-UZ6Q&pullRequest=1264

Check warning on line 291 in Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/EditGroupView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "uiViewController" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy-FIEO4PF7cDTLhfCH&open=AZy-FIEO4PF7cDTLhfCH&pullRequest=1264

Check warning on line 79 in Sources/StreamChatSwiftUI/CommonViews/Avatars/AvatarIndicatorViewModifier.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "switch" statement with "if" statement to increase readability. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WseXgE9ChFi-UZ6K&open=AZy5WseXgE9ChFi-UZ6K&pullRequest=1264

Check warning on line 116 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/ReactionsDetailViewModel.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "controller" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsKggE9ChFi-UZ4K&open=AZy5WsKggE9ChFi-UZ4K&pullRequest=1264

Check warning on line 653 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/MessageActions/DefaultMessageActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "channel" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsMIgE9ChFi-UZ4Y&open=AZy5WsMIgE9ChFi-UZ4Y&pullRequest=1264

Check warning on line 690 in Sources/StreamChatSwiftUI/ChatMessageList/Reactions/MessageActions/DefaultMessageActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "channel" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsMIgE9ChFi-UZ4Z&open=AZy5WsMIgE9ChFi-UZ4Z&pullRequest=1264

Check warning on line 50 in Sources/StreamChatSwiftUI/ChatMessageList/Gallery/ShareButtonView.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "context" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsP1gE9ChFi-UZ4o&open=AZy5WsP1gE9ChFi-UZ4o&pullRequest=1264

Check warning on line 150 in Sources/StreamChatSwiftUI/ChatChannelList/DefaultChannelActions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract the nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WsizgE9ChFi-UZ6U&open=AZy5WsizgE9ChFi-UZ6U&pullRequest=1264

Check failure on line 229 in Sources/StreamChatSwiftUI/Styles.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swiftui&issues=AZy5WskfgE9ChFi-UZ6j&open=AZy5WskfgE9ChFi-UZ6j&pullRequest=1264
View more details on SonarQubeCloud