Skip to content

V5: Poll attachment view redesign#1269

Merged
laevandus merged 6 commits intov5from
v5-poll-attachment-redesign
Mar 6, 2026
Merged

V5: Poll attachment view redesign#1269
laevandus merged 6 commits intov5from
v5-poll-attachment-redesign

Conversation

@laevandus
Copy link
Contributor

@laevandus laevandus commented Mar 5, 2026

πŸ”— Issue Links

Related: IOS-1441

🎯 Goal

Redesign poll attachment view

πŸ“ Summary

Provide bullet points with the most important changes in the codebase.

πŸ›  Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
Before After

πŸ§ͺ Manual Testing Notes

Explain how this change can be tested manually, if applicable.

β˜‘οΈ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@laevandus laevandus requested a review from a team as a code owner March 5, 2026 14:17
@laevandus laevandus marked this pull request as draft March 5, 2026 14:17
@laevandus laevandus changed the title Poll attachment view redesign V5: Poll attachment view redesign Mar 5, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3fdc7d4b-bdfa-4296-9182-9de0bc691e52

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • πŸ” Trigger review
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch v5-poll-attachment-redesign

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

1 Message
πŸ“– There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@laevandus laevandus marked this pull request as ready for review March 6, 2026 12:14
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Public Interface

πŸš€ No changes affecting the public interface.

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title v5 branch diff status
StreamChatSwiftUI 9.91 MB 9.94 MB +35 KB 🟒

@Stream-SDK-Bot
Copy link
Collaborator

StreamChatSwiftUI XCSize

Object Diff (bytes)
PollAttachmentView.o +26910
RadioCheckView.o +4813
PollAllOptionsView.o +204
StreamChatCommonUI_-2A9222176197F8FB_PackageProduct +80
PollCommentsView.o -80
ImageLoadingOptions.o +52
AvatarStack.o -44
MessageContainerView.o -44

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
78.3% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

@laevandus laevandus merged commit f233baf into v5 Mar 6, 2026
11 of 12 checks passed
@laevandus laevandus deleted the v5-poll-attachment-redesign branch March 6, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants