Added a method for configuring the channel alert type #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
…iftui into channel-alert-open
|
nuno-vieira
reviewed
Apr 9, 2025
| @@ -217,13 +217,17 @@ open class ChatChannelListViewModel: ObservableObject, ChatChannelListController | |||
| controller.deleteChannel { [weak self] error in | |||
| if error != nil { | |||
| // handle error | |||
| self?.channelAlertType = .error | |||
| self?.setChannelAlertType(.error) | |||
There was a problem hiding this comment.
Does the customer have access to the actual error? 🤔 Otherwise, if they want to display an alert depending on the error type, it will be difficult. To make this more flexible, we should have at least in the future something like we do on the ThreadList, where a customer can totaly customize the Error view by implementing a modifier: https://getstream.io/chat/docs/sdk/ios/swiftui/thread-list/#thread-list-states
There was a problem hiding this comment.
yes, we can expose a modifier in the future. Basically this customer wants to disable all errors.
nuno-vieira
approved these changes
Apr 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-771/%5Bswiftui%5D%5Bcare%5D-make-channel-list-error-customizable.
🎯 Goal
Make it easier to configure the error popup in the channel list view.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
docs-contentrepo