Skip to content

Fix issue where call.Participants did not always contain the local pa… #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sierpinskid merged 3 commits into from
Nov 23, 2025
Merged

Fix issue where call.Participants did not always contain the local pa… #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f0a3eb
Fix issue where call.Participants did not always contain the local pa…
sierpinskid Nov 23, 2025
7cde1eb
allow empty reason + log errors duing sending leave call as warning
sierpinskid Nov 23, 2025
dd841e0
Change to warning
sierpinskid Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Packages/StreamVideo/Runtime/Core/LowLevelClient/RtcSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ public async Task StopAsync(string reason = "")
}
catch (Exception e)
{
_logs.Error($"Failed to send final stats on leave: {e.Message}");
_logs.Warning($"Failed to send final stats on leave: {e.Message}");
}

#if STREAM_DEBUG_ENABLED
Expand Down
19 changes: 13 additions & 6 deletions Packages/StreamVideo/Runtime/Core/LowLevelClient/WebSockets/SfuWebSocket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public void SendLeaveCallRequest(string reason = "")

if (reason == null)
{
throw new ArgumentException($"{nameof(reason)} is null.");
reason = "reason not provided";
}

#if STREAM_DEBUG_ENABLED
Expand Down Expand Up @@ -298,15 +298,22 @@ protected override async Task OnDisconnectingAsync(string closeMessage)

using (new TimeLogScope("Sending leave call request", Logs.Info))
{
SendLeaveCallRequest(closeMessage);

for (int i = 0; i < 60; i++)
try
{
if (SendQueueCount > 0)
SendLeaveCallRequest(closeMessage);

for (int i = 0; i < 60; i++)
{
await Task.Delay(5);
if (SendQueueCount > 0)
{
await Task.Delay(5);
}
}
}
catch (Exception e)
{
Logs.Warning("Failed to send LeaveCallRequest during disconnect: " + e.Message);
}
}

await base.OnDisconnectingAsync(closeMessage);
Expand Down
16 changes: 14 additions & 2 deletions Packages/StreamVideo/Runtime/Core/Models/CallSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,20 @@ void IStateLoadableFrom<CallSessionResponseInternalDTO, CallSession>.LoadFromDto
_acceptedBy.TryReplaceValuesFromDto(dto.AcceptedBy);
EndedAt = dto.EndedAt;
Id = dto.Id;
_participants.TryReplaceTrackedObjects(dto.Participants, cache.CallParticipants);
_participantsCountByRole.TryReplaceValuesFromDto(dto.ParticipantsCountByRole);

// CallSessionResponseInternalDTO usually (or always?) contains no participants. Participants are updated from the SFU join response
// But SFU response can arrive before API response, so we can't override participants here because this clears the list
foreach (var dtoParticipant in dto.Participants)
{
var participant = cache.TryCreateOrUpdate(dtoParticipant);
if (!_participants.Contains(participant))
{
_participants.Add(participant);
}
}

// StreamTODO: figure out how to best handle this. Should we update it from coordinator or only the SFU
//_participantsCountByRole.TryReplaceValuesFromDto(dto.ParticipantsCountByRole);
_rejectedBy.TryReplaceValuesFromDto(dto.RejectedBy);
StartedAt = dto.StartedAt;
LiveEndedAt = dto.LiveEndedAt;
Expand Down
Loading