Fixes issue #10 #18
Closed
Fixes issue #10 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added css for responsive table
|
Thanks for the PR.. i'll take a look at it asap! |
Gioni06
requested changes
Oct 2, 2019
There was a problem hiding this comment.
Hey. I had the chance to look at your changes. The idea of converting the table rows to a card-style layout is great, but I don't think we are quite there yet.
What do you think of an implementation like this?
https://www.jering.tech/articles/card-style-css-only-responsive-tables
|
Ok I will try to do it |
|
@ShivamRawat0l Any updates on this PR ? |
|
Sorry. I got exams therefore i am busy this month. |
|
@ShivamRawat0l Still interested in this MR? |
I ll try my best if get an opportunity. Might take time : ) |
|
since there is no movement on this issue I'll close this PR. When you're interested in this issue, just reopen it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added css for responsive table. fixes #10