Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix character injection #1919

Closed
wants to merge 11 commits into from
Closed

Fix character injection #1919

wants to merge 11 commits into from

Conversation

kevinmessiaen
Copy link
Member

Description

Fix character injection import issue

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

Copy link

sonarcloud bot commented Jun 10, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@alexcombessie
Copy link
Member

Hey @kevinmessiaen - Is this PR ready for review?

Copy link

sonarcloud bot commented Oct 15, 2024

@alexcombessie
Copy link
Member

Hey @kevinmessiaen - could you have a look at this PR please?

@mattbit
Copy link
Member

mattbit commented Oct 31, 2024

Let's not mess with the user's environment. If needed to avoid specific problems with xgboost, the users should set the env variable themselves.

The original warning is:

Hint: This means that multiple copies of the OpenMP runtime have been linked into the program. That is dangerous, since it can degrade performance or cause incorrect results. The best thing to do is to ensure that only a single OpenMP runtime is linked into the process, e.g. by avoiding static linking of the OpenMP runtime in any library. As an unsafe, unsupported, undocumented workaround you can set the environment variable KMP_DUPLICATE_LIB_OK=TRUE to allow the program to continue to execute, but that may cause crashes or silently produce incorrect results.

So we don't want to set KMP_DUPLICATE_LIB_OK.

@mattbit mattbit closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants