Skip to content

Fix regional caching of tag cache #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix regional caching of tag cache #3504

wants to merge 2 commits into from

Conversation

conico974
Copy link
Contributor

@conico974 conico974 commented Jul 25, 2025

The regional tag cache was kind of broken.
If one tag was revalidated and some cache entry using it was updated, it would make other cache entry depending on that tag cache thinks that they were not stale.

It was very visible for customization update on a multi section website.

Still need some test (especially deployed), and ideally we'd need to find a way to test this in an e2e test.

This need to be backported to OpenNext.

One question here is : Do we prefer to have 1 cache entry per tag, or one per each incremental cache entry ?

Link to the OpenNext PR opennextjs/opennextjs-cloudflare#820

Copy link

linear bot commented Jul 25, 2025

Copy link

changeset-bot bot commented Jul 25, 2025

⚠️ No Changeset found

Latest commit: 2df100f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) ⚠️ Changes detected (Review) 4 changed Jul 25, 2025, 12:47 PM
v2-cloudflare (Inspect) ⚠️ Changes detected (Review) 4 changed Jul 25, 2025, 12:51 PM
v2-vercel (Inspect) ⚠️ Changes detected (Review) 1 changed Jul 25, 2025, 12:48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant