Fix null contentRef handling in RecordColumnValue #3566
Conversation
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
| @@ -110,3 +110,7 @@ export function getColumnVerticalAlignment(column: DocumentTableDefinition): Ver | |||
|
|
|||
| return 'self-center'; | |||
| } | |||
|
|
|||
| export function isContentRef(ref: DocumentTableRecord['values'][string]): ref is ContentRef { | |||
There was a problem hiding this comment.
Hum, why do we need this?
We should not have to check types dynamically; the API should return what it says. Otherwise it's a problem on GBX.
There was a problem hiding this comment.
Steven already made the change in GBX to the API https://github.com/GitbookIO/gitbook-x/pull/19236.
isContentRef is not necessarily needed, ref can be null | ContentRef
There was a problem hiding this comment.
Actually I think the isContentRef is the good solution here, by nature we can't easily type a Table as it is a user created type.
The type of DocumentTableRecord['values'][string] is string | number | boolean | string[] | ContentRef | null
Not sure if we can type this one that much better without overcomplicating things
Improve handling of contentRef to prevent null values and ensure proper resolution in the RecordColumnValue function. Introduce a utility function to validate contentRef objects.