Open
Conversation
|
commit: |
Collaborator
|
@rodrcastro Codex made some changes to the CLI I don’t think we want 😓 |
Author
|
@addisonschultz Sorry, didn't notice! Removed that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was done with help from Codex.
Summary:
Freshdesk now has regions in their widget URLs (ie: https://euc-widget.freshworks.com/widgets/20600000051
8.js) so our previous approach of using just
widget.freshwork.com/widgets/{id}wasn't working for some customers. This should allow the user to paste the full URL of the widget from the widget src and load the correct one.Codex also implemented a backwards-compatible piece to allow widget IDs to still be used and not break it for those that had it working before.