Revert "Try not caching journey test dependencies" #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf2abdb, the supporting change in GitoxideLabs#1725 that refrained from caching build artifacts from the `test-journey` job, since that no longer needs to be avoided now that `git-daemon` journey tests aren't run on CI. In 9566488 (GitoxideLabs#1634), journey tests that use `git-daemon` were disabled on CI. GitoxideLabs#1725 tried reenabling them (65788e8) and fixing them by no longer caching build artifacts with the `rust-cache` action in the `test-journey` job (bf2abdb). This worked at the time, but the exact reason it worked or how reliable it would be were unknown. It stopped working shortly thereafter in 25b8480 (GitoxideLabs#1726), and those journey tests were re-disabled on CI in d1d3f7c, which reverted 65788e8. However, bf2abdb was not reverted at that time. (The change in d1d3f7c from GitoxideLabs#1726, taken together with this commit, effectively constitute a revert of PR GitoxideLabs#1725.)
|
Thanks a lot for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bf2abdb, the supporting change in #1725 that refrained from caching build artifacts from the
test-journeyjob, since that no longer needs to be avoided now thatgit-daemonjourney tests aren't run on CI.In 9566488 (#1634), journey tests that use
git-daemonwere disabled on CI. #1725 tried reenabling them (65788e8) and fixing them by no longer caching build artifacts with therust-cacheaction in thetest-journeyjob (bf2abdb). This worked at the time, but the exact reason it worked or how reliable it would be were unknown. It stopped working shortly thereafter in 25b8480 (#1726), and those journey tests were re-disabled on CI in d1d3f7c, which reverted 65788e8. However, bf2abdb was not reverted at that time.(The change in d1d3f7c from #1726, taken together with this commit, effectively constitute a revert of PR #1725.)
I think it's faster with caching. I estimated that it would be a couple minutes faster usually, but when I test it on my fork it's closer to being only a minute faster, and sometimes not even that much faster.
A possible further benefit of caching, though minor, is that it reliably produces the problem on CI if the now-skipped
git-daemonjourney test cases are enabled: That would be bad if they were enabled, but it's one less change to make to produce the problem in any further work that attempts to reliably produce the problem to investigate it.You might prefer phrasing such as "we did not know why it worked" over the current "the exact reason it worked [was] unknown." I've clarified why I thought it might help and why I think timing may still be the issue in #1726 (comment). But I am not at all attached to any wording here and I'd be pleased to rebase to reword the message if desired.