fix: cargo-auditable build error #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
requested changes
Apr 5, 2025
There was a problem hiding this comment.
Thanks a lot!
I think there needs to be a comment around these, otherwise these will seem like an oversight and changed back sometime in the future. These comments should contain links for more context.
#1024 is a decent description of what's going on, and it doesn't look like the reported bug in Cargo is fixed yet.
Use `futures-lite` instead of `dep:futures-lite` in gix-packetline and gix-protocol. See-Also: rust-secure-code/cargo-auditable#124
Prince213
force-pushed
the
fix-cargo-auditable
branch
from
25b6e3d to
11bd59f
Compare
13 tasks
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
futures-liteinstead ofdep:futures-litein gix-packetline and gix-protocol.This currently affects NixOS.
Related:
gitoxideversions rust-secure-code/cargo-auditable#124