Return correct type on purge when limit has been reached. #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a test, before the fix: After the fix: |
|
@RoySegall Ready for code review. |
RoySegall
reviewed
Apr 3, 2017
| $this->assertEqual(count($messages), 8, t('Eight messages of type 2 left.')); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
First line of the php doc block need to in a single line.
|
What the settings of your installation? I've set up a message type with purge limit of 2 and set the global purge to 10(like in the tests) and created 30 messages and the cron ran OK. |
|
@RoySegall I ran the tests on a clean installation. |
|
I don't think so because when running the tests a clean env. is created for the tests. |
|
I don't understand, let's discuss when you have time. |
|
@RoySegall Fixed your comment, so you are saying that you are running this test on master ( |
|
Back then - yes. I can test it again. |
|
@RoySegall Please :) |
This was referenced Aug 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#184