Fix login redirect bug #8
Conversation
The script sends a summary message to Slack after a CI job completes, handling retries and logging failures.
Add CI workflow for linting, testing, and building
There was a problem hiding this comment.
Pull request overview
This PR adds CI/CD infrastructure for Slack notifications and Jekyll site building. The changes introduce a new Slack alerting script for CI job notifications and a GitHub Actions workflow for building Jekyll sites using Docker.
Key Changes:
- Adds a Slack notification script with retry logic and fallback logging for CI job status alerts
- Adds a Jekyll Docker build workflow for automated site generation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/slack-alert.js | Introduces a new Node.js script to send Slack notifications after CI jobs complete, with exponential backoff retry logic and fallback logging |
| .github/workflows/jekyll-docker.yml | Adds a GitHub Actions workflow to build Jekyll sites using Docker containers on push/PR to main branch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const res = await fetch(url, { | ||
| method: 'POST', | ||
| headers: { 'Content-Type': 'application/json' }, | ||
| body: JSON.stringify(payload), | ||
| // Node 18 global fetch used; if older node, add node-fetch in package.json |
There was a problem hiding this comment.
The comment mentions that Node 18's global fetch is being used, but there's no validation that the fetch API is available. If this code runs on Node versions prior to 18 (where fetch is not globally available), it will fail with a ReferenceError. Consider adding a check or ensuring the Node version requirement is documented and enforced.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
xpertforextradeinc
merged commit 5b924c7
into
github/workflows/ci.yml
What does this PR do?
Fixes an issue where users were redirected to an incorrect page after logging in.
Why is this change needed?
The incorrect redirect caused confusion and prevented users from reaching their intended destination.
How was this tested?
Related issues
N/A