Modernize contextMenus sample to use Google Search parameters instead…#1666
Open
Shreyans-704 wants to merge 2 commits intoGoogleChrome:mainfrom
Open
Modernize contextMenus sample to use Google Search parameters instead…#1666Shreyans-704 wants to merge 2 commits intoGoogleChrome:mainfrom
Shreyans-704 wants to merge 2 commits intoGoogleChrome:mainfrom
Conversation
… of TLD-based domains
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1653
Summary
Update the
global_context_searchsample to reflect modern Google Search behavior. The previous implementation relied on domain-based localization (e.g., google.ca, google.co.jp), which no longer affects search results.Changes
https://www.google.com/searchcr(country restriction): e.g.,countryCA,countryJP,countryRUlr(language restriction): e.g.,lang_en,lang_ja,lang_rulocales.jsinto a structuredregionsconfiguration objectWhy
Modern Google Search localizes results primarily based on IP geolocation, making domain-based localization ineffective. Using
crandlrparameters provides a more accurate and programmatic way to demonstrate regional search differences.Testing