Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: puppeteer script to test a page from devtools #12145
misc: puppeteer script to test a page from devtools #12145
Changes from 19 commits
a7c9b7c
2bfab03
5600580
f1f482c
f55af1a
2610184
eb46ce9
c02565e
64db3dd
031aff0
92bf401
327aad7
e388a0b
f9cb0ab
9362eb2
e789cf6
9d5e1ff
ce32999
44ef3c2
eff36a1
e9cbda1
ee3aad5
f1789cc
cc269a0
c01ce58
92a3b56
ff8ba75
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this working for you locally still? When I run it it seems like this line isn't succeeding (it's stuck on the elements panel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working fine for me on the latest Canary, but I was having issues earlier with a custom DT frontend.
Can you try opening DT on DT and running this line manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need to add an extra
ViewManager
?https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/front_end/test_runner/TestRunner.js;l=264-270?q=TestRunner.js&ss=chromium%2Fchromium%2Fsrc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do
const ViewManager = UI.ViewManager.ViewManager || UI.ViewManager; ...
so it works in stable and canary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: The issue here was that
CHROME_PATH
wasn't set, so puppeteer defaulted to M78 which uses the "Audits" panel instead of the "Lighthouse" panel.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've upgraded our puppeteer dep: #12284
This file was deleted.